Hopefully the three different angles gives you a good view to trace the wires.
I can't tell everything about the wiring from these views, but I CAN see enough to understand the tone control problem. There are 2 errors.
1 - The tone cap is in the wrong place in relationship to the top tone control. But it is correct in relationship to the bottom tone control.
A - One end of the tone cap should connect directly to ground.
B - One lug (either wiper or CCW end) of each tone pot should connect to the other end of the cap. (the end not connected to ground)
C - The other lug (either wiper or CCW end) of each tone pot should connect to the selector switch (via the red wires).
D - The case of the pots can and should be connected to ground for shielding. But none of the
lugs of either tone pot can be connected directly to ground.
That explains why the upper tone control was acting like a volume control.
Why it acts like a volume control for the
bridge pickup:
The top tone control is connected to the wrong lug of the pickup switch. If you want the top tone control to affect the neck pickup, move the skinny red wire on the far right lug of the selector switch to the unused lug, immediately to the left of the thick red wire. (use second or third pic for reference)
The selector switch you have should work as follows:
N M B C C N M B
N = Neck
M = Middle
B = Bridge
C = Common
The left and right half of each switch
could be wired independently, but in your case, both the commons are connected together. The lugs on the left side select which pickup(s) are connected, the lugs on the right side select which tone control(s) work.
Edit:Ok first thing replace those pots they look like hell try alpha or CTS.
erm...no.
1 - CTS doesn't make a push-pull pot with a DPDT switch. Only SPST. He needs at least DPST or better to split two pickups with one switch. CTS is out of the running here.
2 - Pretty sure the upper tone pot
is an Alpha. The volume pot appears to be a DiMarzio. Both are considered good quality push-pull pots.
3 - f
k what they
look like. If they work well, that's all that counts. If either was noisy or otherwise defective, then fine replace. Else leave well enough alone.
4 - Replacing parts while retaining incorrect wiring won't solve the problem. Unless the problem is that your wallet is too heavy.