I didn't check all the way through the 5-way. Looking at the 5-way in position 2, it looks like the rotary works fine. I'd assume that the rest is fine too.
At least for this one position of the 5-way, I think that the jumpers to postion 1 and 2 on the bottom-most pole of the rotary are unnecessary. They connect the bottom wire of the unused pickups to ground. Maybe you need that for the other functions?
As for rotary switches, these aren't exactly the mil-spec ones that ChrisK used to recommend, but I've got 12 of this type installed in 4 guitars, and another in a pedal and am perfectly satisfied. Mostly I've used the DP5T version, but I do have this exactly 4P3T in my Rick. I know from experience that these will not withstand excessive attempts to exceed their rotational limits. That is, they will break if you try too hard to turn them too far, but when you're turning them the right way, the action is really easy and smooth.
The one thing is that that the shafts are a full 1/4" in either round (as linked) or D-shaft. These do not fit knobs meant for split knurled shafts like on most Fender and Gibson guitars. They fit exactly the set-screw knobs on my Rick, but I had to ream out the strat knobs, and even the set-screw Tele style knob on my LP.